Improve accelerator key detection#2061
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Jan 28, 2022
Merged
Conversation
Collaborator
|
Rebase and push now the Linux build should work, please :). |
Merge base class with its derived class for dialogs. Don't skip unfinished translations, as they still get used.
softins
force-pushed
the
checkkeys-update
branch
from
5b5c2a1 to
4244f63
Compare
Collaborator
|
Can anyone check this or should it just get merged? |
hoffie
approved these changes
Jan 21, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Looks good to me.
Not sure if it is supposed to find something when started within this PR, for me it doesn't, but maybe that's simply because everything is ok. :)
pljones
approved these changes
Jan 21, 2022
ann0see
reviewed
Jan 28, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Please merge if this is ready.
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 10, 2022
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 11, 2022
1 task
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 11, 2022
ann0see
added a commit
that referenced
this pull request
Feb 11, 2022
ChangeLog: Add translations for 3.8.2 & #2061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Merge base class with its derived class for dialogs (e.g. CClientDlgBase and CClientDlg)
Don't skip unfinished translations, as they still get used.
Context: Fixes an issue?
Just a tool used during the release process. It is just an aid to human checking, and not used for building the software.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Ready to merge
Checklist