Prevent setting 'Run Jamulus' if driver not found#2103
Merged
pljones merged 3 commits intojamulussoftware:masterfrom Dec 31, 2021
Merged
Prevent setting 'Run Jamulus' if driver not found#2103pljones merged 3 commits intojamulussoftware:masterfrom
pljones merged 3 commits intojamulussoftware:masterfrom
Conversation
pljones
reviewed
Nov 1, 2021
henkdegroot
changed the title
henkdegroot
changed the title
Collaborator
|
@henkdegroot Are you okay to fix the conflicts? |
Contributor
Author
|
@pljones I wasn't sure if I could/should do that or not. I have have resolved the conflicts now. |
Member
|
The JACK build failed… |
Contributor
Author
It failed because JACK could not be installed in the prepare for windows step. |
Contributor
Author
|
@ann0see, pretty annoying but this time NSIS download failed. This seems to be happening very often lately, I don't know why. Can you do another re-run please? |
Contributor
Author
|
Finally passed the autobuild 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Installer option to run the Jamulus Client after installation will be set to unchecked when the installation is performed without an audio driver
Context: Fixes an issue?
Fixes: #2099
Does this change need documentation? What needs to be documented and how?
No documentation update required
Status of this Pull Request
Local build tested with and without ASIO driver and JACK installed
What is missing until this pull request can be merged?
Nothing
Checklist