Server tray icon update#2231
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Jan 10, 2022
Merged
Conversation
pljones
approved these changes
Jan 10, 2022
Collaborator
|
@gilgongo as there are Server documentation changes being made, can this be picked up? Or would you rather a separate change? |
ann0see
approved these changes
Jan 10, 2022
Member
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Tested on Windows JACK version and it seems to be ok.
Member
|
I guess I can put it into the server docs change as a new section that says what the dot means, yes. |
Member
|
Reminder to self: pull this into the separate update for 3.8.2 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Server tray icon update
Sample screenshots
Windows Inactive State:
Windows Active State:
macOS Inactive State:
macOS Active State:
Context: Fixes an issue?
Fixes: #2112
Does this change need documentation? What needs to be documented and how?
The current documentation does not explain the two different states of the icon. It would be nice to have this included in the server manual.
Status of this Pull Request
Complete
What is missing until this pull request can be merged?
Nothing
Checklist