Skip to content

src/buffer.cpp: Avoid CodeQL warning about multiplication overflow #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ann0see merged 2 commits into from
Jan 27, 2022
Merged

src/buffer.cpp: Avoid CodeQL warning about multiplication overflow #2292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d241062
Avoid CodeQL warning about multiplication overflow
softins Jan 26, 2022
85e3c4c
Added explanatory comments
softins Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ bool CNetBuf::Put ( const CVector<uint8_t>& vecbyData, int iInSize )
const int iNumBlocks = /* floor */ ( iInSize / iBlockSize );

// copy new data in internal buffer
for ( int iBlock = 0; iBlock < iNumBlocks; iBlock++ )
// iBlock is a long to avoid overflowing a mulitplication later in the code
for ( long iBlock = 0; iBlock < iNumBlocks; iBlock++ )
Comment thread
softins marked this conversation as resolved.
{
// extract sequence number of current received block (per definition
// the sequence number is appended after the coded audio data)
Expand Down Expand Up @@ -263,7 +264,8 @@ bool CNetBuf::Put ( const CVector<uint8_t>& vecbyData, int iInSize )
// copy new data in internal buffer
const int iNumBlocks = iInSize / iBlockSize;

for ( int iBlock = 0; iBlock < iNumBlocks; iBlock++ )
// iBlock is a long to avoid overflowing a mulitplication later in the code
for ( long iBlock = 0; iBlock < iNumBlocks; iBlock++ )
Comment thread
softins marked this conversation as resolved.
{
// for simultion buffer only update pointer, no data copying
if ( !bIsSimulation )
Expand Down