debian/control: Fix License header & show Volker's copyright#2325
Conversation
According to the headers in the code, Jamulus is "GPL v2 or later". The proper tag for this is GPL-2+. https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-syntax
|
LGTM |
| @@ -10,4 +10,4 @@ for file in $(find android ios linux mac src windows -regex '.*\.\(cpp\|h\|mm\)' | |||
| sed -re 's/(\*.*Copyright.*[^-][0-9]{4})(\s*-\s*\b[0-9]{4})?\s*$/\1-'"${YEAR}"'/' -i "${file}" | |||
There was a problem hiding this comment.
Here and line 6 are also brought into question, perhaps?
There was a problem hiding this comment.
Do you mean the regexp? I've adjusted the other instance because it's a different format (multi-line value in debian/control)
There was a problem hiding this comment.
I just meant does the same reasoning - splitting the Copyright line - also apply to the file headers on the source, as well as the debian copyright message. I'm not sure most of them credit the contributors (although I've tended to add myself).
There was a problem hiding this comment.
Ah, yeah.
I've also thought about those multiple times, but didn't come to a good solution.
Yes, most contributors are missing.
- We could add everyone based on git history, but this will get out of hands.
src/utils.cppwould show 33 author lines, from a quick glance (git log --format='format:%an' src/util.cpp | sort -u | wc -). - Listing only Volker tends to become less valid over time.
- Dropping authors altogether and listing them somewhere else instead (
src/utils.cppdoes) would also imply to drop Volker's name, which does not sound nice to me. - Maybe a compromise would be
Volker Fischer, The Jamulus Development Team and contributors?
There was a problem hiding this comment.
Probably worth raising as a separate issue for now.
4 participants
Short description of changes
@trebmuh pointed out in #2321 (comment) that we should probably keep Volker listed as Copyright holder in the
debian/controlfile for the past years. I struggled what years to put in, but came up with the following:I hope that this addresses all concerns.
2004 was the begin of Jamulus according to
main.cpp.2021 was when Volker left and the Jamulus Development Team took over.
and contributorshopefully covers the fact that both in previous times and nowadays lots of code is provided by individual contributors. That would hopefully cover @pljones's early contributions, as well as @corrados' recent contribution.This PR also fixes the
License:field, which statedGPL-2, while it should beGPL-2 or lateraccording to the file header (e.g.src/main.cpp). The proper tag for that isGPL-2+.Context: Fixes an issue?
#2321 (comment)
Does this change need documentation? What needs to be documented and how?
No.
CHANGELOG: SKIP
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
/
Checklist
My code follows the style guide