Add basic translation verification check#2338
Merged
gilgongo merged 2 commits intojamulussoftware:masterfrom Feb 15, 2022
Merged
Add basic translation verification check#2338gilgongo merged 2 commits intojamulussoftware:masterfrom
gilgongo merged 2 commits intojamulussoftware:masterfrom
Conversation
Member
Author
|
Ok. Probably an easy and little thing. Probably ready to merge. |
Member
Author
|
Should be squash merged |
Member
|
Note: This was intentionally reverted in 3343167 as far as I see. |
Member
Author
|
Yes only parts of it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Executes windows installer verification script and checkkeys.pl on push to src/res/translation
Context: Fixes an issue?
No. There was some discussion around that.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Still being tested. Probably not much to do.
What is missing until this pull request can be merged?
Seems to work: https://github.com/ann0see/jamulus/actions/runs/1791182911 (Although we don't seem to check for syntax errors in the win installer test yet)
Checklist