Remove trailing white-space in files#2402
Conversation
ann0see
left a comment
There was a problem hiding this comment.
I think this is not dangerous to merge - maybe clang-format should handle this (probably it already does but not for the files here.)
pljones
left a comment
There was a problem hiding this comment.
I'd rather not include this in 3.8.2 now as it's not a blocker on releasing rc1, unlike the translations.
|
Could be done with dos2unix, I think? |
|
Ok @hoffie : I Included the fix as commit in this PR. |
ann0see
left a comment
There was a problem hiding this comment.
How much sense does it make to include unfinished files in main? Shouldn't we put them in a feature branch?
| // clang-format on | ||
| } | ||
| bool CLlconVST::GetName ( char* cName ) |
There was a problem hiding this comment.
The vst code could also all get moved to a (dead) feature branch.
There was a problem hiding this comment.
Yes. I think that's best.
|
Should not be squash merged. |
|
Should be merged after upcoming release (not squash merged). |
Short description of changes
Context: Fixes an issue?
No, but hopefully stops cluttered diffs.
Fixes: #2360
Does this change need documentation? What needs to be documented and how?
CHANGELOG: Internal: Remove unneeded white-space in all files and streamline line endings
Status of this Pull Request
Ready to be merged if CI is ok.
What is missing until this pull request can be merged?
Checklist