Work around CodeQL multiplication warning#2456
Closed
softins wants to merge 1 commit intojamulussoftware:masterfrom
Closed
Work around CodeQL multiplication warning#2456softins wants to merge 1 commit intojamulussoftware:masterfrom
softins wants to merge 1 commit intojamulussoftware:masterfrom
Conversation
Collaborator
It fixes a CodeQL issue, so it's a definite improvement (i.e. builds won't fail annoyingly). So I think it should have a change log entry. |
Member
Author
|
Actually, I've just noticed a more general issue in |
Member
Author
|
In fact, I'll just close this and raise a fresh PR with more meaningful branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Work around CodeQL multiplication overflow warning by performing the multiply in advance.
This is also slightly more efficient, as the product is potentially used twice.
CHANGELOG: SKIP
Context: Fixes an issue?
Fixes a CodeQL warning in the CI. No user-visible difference.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Complete. Didn't find any more potential instances.
What is missing until this pull request can be merged?
CI success for Android build
Checklist