Merged
Conversation
VST code is now on a feature branch (feature/vst) https://github.com/jamulussoftware/jamulus/tree/feature/vst since there hasn't been any development for years. Fixes: jamulussoftware#2405
ann0see
force-pushed
the
patch/remove-vst
branch
from
1aa2cbd to
8c8caff
Compare
ann0see
commented
Mar 4, 2022
Comment on lines
+44
to
63
| #if defined( _WIN32 ) && !defined( JACK_REPLACES_ASIO ) | ||
| # include "../windows/sound.h" | ||
| #else | ||
| # if defined( _WIN32 ) && !defined( JACK_REPLACES_ASIO ) | ||
| # include "../windows/sound.h" | ||
| # if ( defined( Q_OS_MACX ) ) && !defined( JACK_REPLACES_COREAUDIO ) | ||
| # include "../mac/sound.h" | ||
| # else | ||
| # if ( defined( Q_OS_MACX ) ) && !defined( JACK_REPLACES_COREAUDIO ) | ||
| # include "../mac/sound.h" | ||
| # if defined( Q_OS_IOS ) | ||
| # include "../ios/sound.h" | ||
| # else | ||
| # if defined( Q_OS_IOS ) | ||
| # include "../ios/sound.h" | ||
| # ifdef ANDROID | ||
| # include "../android/sound.h" | ||
| # else | ||
| # ifdef ANDROID | ||
| # include "../android/sound.h" | ||
| # else | ||
| # include "../linux/sound.h" | ||
| # ifndef JACK_REPLACES_ASIO // these headers are not available in Windows OS | ||
| # include <sched.h> | ||
| # include <netdb.h> | ||
| # endif | ||
| # include <socket.h> | ||
| # include "../linux/sound.h" | ||
| # ifndef JACK_REPLACES_ASIO // these headers are not available in Windows OS | ||
| # include <sched.h> | ||
| # include <netdb.h> | ||
| # endif | ||
| # include <socket.h> | ||
| # endif | ||
| # endif |
Member
Author
There was a problem hiding this comment.
This whole thing looks ugly. Isn't there anything like an else if construct?
pljones
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VST code is now on a feature branch (feature/vst) https://github.com/jamulussoftware/jamulus/tree/feature/vst since there hasn't been any development for years.
Fixes: #2405
Short description of changes
Removes VST code. Should be tested.
CHANGELOG: Internal: Moved outdated VST code on feature branch since there hasn't been any active development for a long time. Work can still be continued from the feature branch feature/vst
Context: Fixes an issue?
Fixes: #2405
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Not sure. Since I only removed code which was already if def'd I doubt there's much which can go wrong?
Checklist