Remove windows/qt-installer-windows.qs since no longer used#2516
Merged
ann0see merged 2 commits intojamulussoftware:masterfrom Mar 18, 2022
Merged
Remove windows/qt-installer-windows.qs since no longer used#2516ann0see merged 2 commits intojamulussoftware:masterfrom
ann0see merged 2 commits intojamulussoftware:masterfrom
Conversation
Since Travis Ci is no longer used, the qt-installer-windows.qs file is no longer needed. Fixes: jamulussoftware#2515
Member
|
I usually argue against "can you additionally do $OTHER_THING" in PRs, but in this case I think at least the closely related updating part of COMPILING.md could be done as part of this PR? I.e. remove the reference to this file and replace it with a reference to the Windows autobuild script? |
pljones
approved these changes
Mar 16, 2022
Member
Author
|
@hoffie I did not add the autobuild script but a reference to Qt 5.15.2. I think we should update this file and not direct the user to some files in Git. |
hoffie
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Since Travis Ci is no longer used, the qt-installer-windows.qs file is no longer needed.
CHANGELOG: Internal: Removed outdated qt-installer-windows.qs since we no longer use Travis CI
Context: Fixes an issue?
Fixes: #2515
Does this change need documentation? What needs to be documented and how?
Yes. The COMPILING.md file should be updated.
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Nothing.
Checklist