Autobuild: Make release changelog generation explicit#2655
Closed
hoffie wants to merge 2 commits intojamulussoftware:masterfrom
Closed
Autobuild: Make release changelog generation explicit#2655hoffie wants to merge 2 commits intojamulussoftware:masterfrom
hoffie wants to merge 2 commits intojamulussoftware:masterfrom
Conversation
This was previously done as part of the variable extraction step. It's rather surprising to have a script with the name "analyze*" write to some Changelog file. Therefore, move all of the generation to the same abstraction level (Github workflow). Fixes jamulussoftware#2480
pljones
approved these changes
Jun 18, 2022
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Autobuild: Use a variable instead of hardcoding the release changelog path twice
Autobuild: Make release changelog generation explicit
This was previously done as part of the variable extraction step.
It's rather surprising to have a script with the name "analyze*" write
to some Changelog file.
Therefore, move all of the generation to the same abstraction level (Github workflow).
CHANGELOG: (List along with the other autobuild improvements)
Context: Fixes an issue?
Fixes #2480
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested on my repo: https://github.com/hoffie/jamulus/runs/6948860313?check_suite_focus=true#step:5:1
What is missing until this pull request can be merged?
Reviews.
Checklist