JSON-RPC: Additional methods for jamulusserver/*#2920
Closed
Rob-NY wants to merge 1 commit intojamulussoftware:mainfrom
Closed
JSON-RPC: Additional methods for jamulusserver/*#2920Rob-NY wants to merge 1 commit intojamulussoftware:mainfrom
Rob-NY wants to merge 1 commit intojamulussoftware:mainfrom
Conversation
…hat send broadcast/connection
Contributor
Author
|
Removing this pull as it has diverged too far from its dependency #2918 which is also still pending. |
Member
|
@Rob-NY As the other PR was finally merged, so you think your other work can also get a new PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
NOTE THIS PR IS DEPENDENT ON #2918 (hence the compile failures -- I can submit both together here if that works better. Not sure how to note this dependency in github)
Added additional RPC methods for notification of connection, disconnection, and chats. Added the ability to send both broadcast chats to all connected clients, or targeted chats to a single connected client.
jamulusserver/clientConnect - a push notification on new client connect containing all info ("all info" is name, ip, instrument code, instrument name, skill code, skill name, country code, country name, city)
jamulusserver/clientDisconnect - a push notification on client disconnect containing channel, name, ip.
jamulusserver/clientInfoChanged - a push notification when a client changes any of their profile information.
jamulusserver/chatReceived - a push notification when a chat is received by the server including channel, name, ip, timestamp, and message.
jamulusserver/sendBroadcastChat - method to broadcast a server-level message to all connected clients.
jamulusserver/sendChat - method to send a chat to any individual connected channel based upon IP address.
Modified RPC methods:
CHANGELOG: Additional RPC methods for connection notification and chat processing.
Context: Fixes an issue?
Issue #2495 and discussion in #2890
Does this change need documentation? What needs to be documented and how?
Yes, RPC documentation updates are included in this PR.
Status of this Pull Request
What is missing until this pull request can be merged?
Linux tested/compiled only.
Checklist