Skip to content

JSON-RPC: Additional methods for jamulusserver/*#2920

Closed
Rob-NY wants to merge 1 commit intojamulussoftware:mainfrom
Rob-NY:rpc_changes_uber1
Closed

JSON-RPC: Additional methods for jamulusserver/*#2920
Rob-NY wants to merge 1 commit intojamulussoftware:mainfrom
Rob-NY:rpc_changes_uber1

Conversation

@Rob-NY
Copy link
Copy Markdown
Contributor

@Rob-NY Rob-NY commented Oct 17, 2022

Short description of changes

NOTE THIS PR IS DEPENDENT ON #2918 (hence the compile failures -- I can submit both together here if that works better. Not sure how to note this dependency in github)

Added additional RPC methods for notification of connection, disconnection, and chats. Added the ability to send both broadcast chats to all connected clients, or targeted chats to a single connected client.

jamulusserver/clientConnect - a push notification on new client connect containing all info ("all info" is name, ip, instrument code, instrument name, skill code, skill name, country code, country name, city)
jamulusserver/clientDisconnect - a push notification on client disconnect containing channel, name, ip.
jamulusserver/clientInfoChanged - a push notification when a client changes any of their profile information.
jamulusserver/chatReceived - a push notification when a chat is received by the server including channel, name, ip, timestamp, and message.
jamulusserver/sendBroadcastChat - method to broadcast a server-level message to all connected clients.
jamulusserver/sendChat - method to send a chat to any individual connected channel based upon IP address.
Modified RPC methods:

CHANGELOG: Additional RPC methods for connection notification and chat processing.

Context: Fixes an issue?

Issue #2495 and discussion in #2890

Does this change need documentation? What needs to be documented and how?

Yes, RPC documentation updates are included in this PR.

Status of this Pull Request

What is missing until this pull request can be merged?

Linux tested/compiled only.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@hoffie hoffie added this to the Release 3.10.0 milestone Oct 17, 2022
@hoffie hoffie changed the title RPC method additions to jamulusserver/* JSON-RPC: Additional methods for jamulusserver/* Oct 17, 2022
@ann0see ann0see changed the base branch from master to main December 26, 2022 19:06
@Rob-NY
Copy link
Copy Markdown
Contributor Author

Rob-NY commented Jan 25, 2023

Removing this pull as it has diverged too far from its dependency #2918 which is also still pending.

@Rob-NY Rob-NY closed this Jan 25, 2023
@ann0see
Copy link
Copy Markdown
Member

ann0see commented May 30, 2023

@Rob-NY As the other PR was finally merged, so you think your other work can also get a new PR?

@pljones pljones removed this from the Release 3.10.0 milestone Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants