Autobuild: Minimize JSON-RPC workflow permissions#2962
Merged
ann0see merged 2 commits intojamulussoftware:masterfrom Dec 26, 2022
Merged
Autobuild: Minimize JSON-RPC workflow permissions#2962ann0see merged 2 commits intojamulussoftware:masterfrom
ann0see merged 2 commits intojamulussoftware:masterfrom
Conversation
hoffie
approved these changes
Nov 19, 2022
Member
hoffie
left a comment
There was a problem hiding this comment.
Looks good to me.
We might even drop the secret in the env fully.
Worth a try. ;)
Member
Author
|
Ok. Removing the token works: Successful run without changes: https://github.com/ann0see/jamulus/actions/runs/3777431973/jobs/6421260779 |
Member
Author
|
I think after this is merged, we can remove even more permissions in GH settings. |
pljones
approved these changes
Dec 26, 2022
Collaborator
pljones
left a comment
There was a problem hiding this comment.
Build is clean -> good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Removes any permissions from JSON-RPC check. We might even drop the secret in the env fully.
It fails as expected if there is a change to the function documentation:
https://github.com/ann0see/jamulus/actions/runs/3505130530
Other change doesn't make the check fail: https://github.com/ann0see/jamulus/actions/runs/3505127551
CHANGELOG: SKIP
Context: Fixes an issue?
No. But related to #1737
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Review by @hoffie
What is missing until this pull request can be merged?
Theoretical review. I might not have thought about all possible cases where this check should be run.
Checklist