Copyright notices: Minimize GitHub workflow permissions#2963
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Nov 20, 2022
Merged
Copyright notices: Minimize GitHub workflow permissions#2963ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
pljones
approved these changes
Nov 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Minimizes permissions for copyright notices workflow. Once the series of PRs are merged, we can change the GH default permissions to read only.
POC:
Copyright change opens PR: https://github.com/ann0see/jamulus/actions/runs/3505273366
And deletes branch:
https://github.com/ann0see/jamulus/actions/runs/3505274807
That's the working PR:
ann0see#87
CHANGELOG: SKIP
Context: Fixes an issue?
Related to: #1737
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Needs review.
What is missing until this pull request can be merged?
Review.
Checklist