Skip to content

Add Unicode Copyright symbol to Copyright notice#3045

Merged
ann0see merged 1 commit intojamulussoftware:mainfrom
ann0see:addCopyright
Apr 19, 2023
Merged

Add Unicode Copyright symbol to Copyright notice#3045
ann0see merged 1 commit intojamulussoftware:mainfrom
ann0see:addCopyright

Conversation

@ann0see
Copy link
Copy Markdown
Member

@ann0see ann0see commented Apr 15, 2023

Short description of changes

Changes the Copyright symbol to the unicode equivalent

Copyright screen

CHANGELOG: SKIP

Context: Fixes an issue?

Fixes: #2903
Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request
Ready for review.

What is missing until this pull request can be merged?

Nothing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.10.0 milestone Apr 15, 2023
@pljones
Copy link
Copy Markdown
Collaborator

pljones commented Apr 15, 2023

This doesn't address the start up banner, then?

 *** Copyright (C) 2005-2023 The Jamulus Development Team

Also, the © symbol can also be expressed (in the .ui file) as ©, I think, which might be easier to edit.
https://www.rapidtables.com/web/html/html-codes/html-code-copyright.html

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Apr 15, 2023

/usr/lib/qt5/bin/uic src/aboutdlgbase.ui -o ui_aboutdlgbase.h
uic: Error in line 72, column 34 : Entity 'copy' not declared.
File 'src/aboutdlgbase.ui' is not valid

I don't think so. I used ©

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Apr 15, 2023

Fixed the other situation too. I hope Windows supports unicode characters in terminal.

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Apr 19, 2023

I'm going to merge this now.

@ann0see ann0see merged commit 88c7ed1 into jamulussoftware:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use © symbol in Copyright screen

2 participants