Skip to content

Build: Windows: Fix Github JACK build failures & improve build speed #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ann0see merged 2 commits into from
Dec 12, 2023
Merged

Build: Windows: Fix Github JACK build failures & improve build speed #3206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc4318
Build: Windows: Improve dependency download speed
hoffie Dec 9, 2023
aeb7239
Autobuild: Ensure JACK install completion
hoffie Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/autobuild/windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ param(
# Fail early on all errors
$ErrorActionPreference = "Stop"

# Invoke-WebRequest is really slow by default because it renders a progress bar.
# Disabling this, improves vastly performance:
$ProgressPreference = 'SilentlyContinue'

$QtDir = 'C:\Qt'
$ChocoCacheDir = 'C:\ChocoCache'
$DownloadCacheDir = 'C:\AutobuildCache'
Expand Down Expand Up @@ -179,7 +183,7 @@ Function Ensure-JACK

$JACKInstallPath = "${DownloadCacheDir}\JACK64.exe"

& $JACKInstallPath $JACKInstallParms
Start-Process -Wait $JACKInstallPath -ArgumentList "$JACKInstallParms"

if ( !$? )
{
Expand All @@ -194,7 +198,7 @@ Function Ensure-JACK

$JACKInstallPath = "${DownloadCacheDir}\JACK32.exe"

& $JACKInstallPath $JACKInstallParms
Start-Process -Wait $JACKInstallPath -ArgumentList "$JACKInstallParms"

if ( !$? )
{
Expand Down
4 changes: 4 additions & 0 deletions windows/deploy_windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ param (
# Fail early on all errors
$ErrorActionPreference = "Stop"

# Invoke-WebRequest is really slow by default because it renders a progress bar.
# Disabling this, improves vastly performance:
$ProgressPreference = 'SilentlyContinue'

# change directory to the directory above (if needed)
Set-Location -Path "$PSScriptRoot\..\"

Expand Down