Skip to content

Updated/reviewed help texts and Spanish translation#330

Merged
corrados merged 20 commits intojamulussoftware:masterfrom
ignotus666:master
Jun 5, 2020
Merged

Updated/reviewed help texts and Spanish translation#330
corrados merged 20 commits intojamulussoftware:masterfrom
ignotus666:master

Conversation

@ignotus666
Copy link
Copy Markdown
Member

Most changes have been to merge the texts reviewed by Gilgongo. All suggestions are welcome.

Comment thread src/clientdlg.cpp
"only be used on fast PCs. If the reverberation level fader is set to "
"minimum (which is the default setting), the reverberation effect is "
"desired reverb level is reached." ) + "<br>" + tr (
"Reverb requires significant CPU so it should "
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this. This is a relic from old times. With modern computers, the CPU requirement should be negligible.

Comment thread src/clientdlg.cpp
ledDelay->setToolTip ( tr ( "If this LED indicator turns red, "
"you will not have much fun using the " ) + APP_NAME +
tr ( " software." ) + TOOLTIP_COM_END_TEXT );
"you will not have much fun using the application" ) +
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a point missing after the application.

@corrados
Copy link
Copy Markdown
Contributor

corrados commented Jun 5, 2020

There are just minor things to change. I'll do it myself after merging.
Thanks.

@corrados corrados merged commit 1a6123f into jamulussoftware:master Jun 5, 2020
@ignotus666
Copy link
Copy Markdown
Member Author

I made those couple of changes and also removed the CPU stuff from manual.md

@corrados
Copy link
Copy Markdown
Contributor

corrados commented Jun 5, 2020

I just noticed that there is a lot of work to do to fix the translation for your changes. I fear that the other contributors will not be happy to have to spend a lot of time again. Maybe they don't do it at all...

@ignotus666
Copy link
Copy Markdown
Member Author

I know, but if we wanted to bring the app's help texts up to date with the manual I don't see what else could have been done... I tried to modify as little as possible apart from the changes that were required to bring the help texts in line with manual.md and sort out some of the +APP NAME+ stuff.

That said, it took me 1/2 an hour to update the translation - there's lots of text that can be 'recycled' from the 'vanished' segments. Editing the src files was a far bigger pain in the ar$e...

@corrados
Copy link
Copy Markdown
Contributor

corrados commented Jun 5, 2020

Ok. Let's see when we get updates from the other translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants