Skip to content

Minor scaling factor fixes #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corrados merged 1 commit into from
Sep 30, 2020
Merged

Minor scaling factor fixes #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions windows/sound.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,8 +580,9 @@ bool CSound::CheckSampleTypeSupported ( const ASIOSampleType SamType )
( SamType == ASIOSTInt32MSB24 ) );
}

// Might want to comment that use of double in factors below avoids nasty conversion surprises
static constexpr double FACTOR16 = 32767.0;
static constexpr double FACTOR16_INV = 1.0 / 32767.0;
static constexpr double FACTOR16_INV = 1.0 / 32768.0; // Notice diff in last digit from other factor, ala Port Audio

struct sample16LSB
{
Expand Down Expand Up @@ -618,8 +619,9 @@ struct sample16MSB
}
};

// Might want to comment that use of double in factors below avoids nasty conversion surprises
static constexpr double FACTOR24 = 2147483647.0;
static constexpr double FACTOR24_INV = 1.0 / 2147483647.0;
static constexpr double FACTOR24_INV = 1.0 / 2147483648.0; // Notice diff in last digit from other factor, ala Port Audio

struct sample24LSB
{
Expand Down Expand Up @@ -663,8 +665,9 @@ struct sample24MSB
}
};

// Might want to comment that use of double in factors below avoids nasty conversion surprises.
static constexpr double FACTOR32 = 2147483647.0;
static constexpr double FACTOR32_INV = 1.0 / 2147483647.0;
static constexpr double FACTOR32_INV = 1.0 / 2147483648.0; // Notice diff in last digit from other factor, ala Port Audio

struct sample32LSB
{
Expand Down