Skip to content

Avoid selecting IPv6 results from hostname lookup (#722) #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corrados merged 1 commit into from
Nov 22, 2020
Merged

Avoid selecting IPv6 results from hostname lookup (#722) #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions src/util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,18 +982,26 @@ bool NetworkUtil::ParseNetworkAddress ( QString strAddress,
// that the string contains a valid host name string
const QHostInfo HostInfo = QHostInfo::fromName ( strAddress );

if ( HostInfo.error() == QHostInfo::NoError )
if ( HostInfo.error() != QHostInfo::NoError )
{
// apply IP address to QT object
if ( !HostInfo.addresses().isEmpty() )
{
// use the first IP address
InetAddr = HostInfo.addresses().first();
}
return false; // invalid address
}
else

// use the first IPv4 address, if any
bool bFoundIPv4 = false;
foreach ( const QHostAddress HostAddr, HostInfo.addresses() )
{
return false; // invalid address
if ( HostAddr.protocol() == QAbstractSocket::IPv4Protocol )
{
InetAddr = HostAddr;
bFoundIPv4 = true;
break;
}
}
if ( !bFoundIPv4 )
{
// only found IPv6 addresses
return false;
}
}

Expand Down