Skip to content

New windows installer now checks if old version of Jamulus is wrongly installed #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corrados merged 4 commits into from
Dec 29, 2020
+28 −6
Merged

New windows installer now checks if old version of Jamulus is wrongly installed #800

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f56e421
Add registry check for old Jamulus version and warn
ann0see Dec 28, 2020
01c5ef3
Only execute check on 64 bit
ann0see Dec 28, 2020
bab1506
Add source and code style changes
ann0see Dec 28, 2020
3ca6391
Check for Uninstaller.exe instead for registry
ann0see Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions windows/installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ LangString RUNNING_APP_MSG ${LANG_ENGLISH} \
; LangString RUNNING_APP_MSG ${LANG_ITALIAN} \
; "${APP_NAME} è in esecuzione. Chiudere l'applicazione prima di eseguire l'installazione."

LangString OLD_WRONG_VER_FOUND ${LANG_ENGLISH} \
"Due to a bug, an old version of Jamulus might be installed to a wrong path on your computer. Do you want to remove it before installing this new version (we strongly recommend this)?"

LangString OLD_WRONG_VER_FOUND_CONFIRM ${LANG_ENGLISH} \
"If you continue without removing it, your installation might be broken! Are you sure you don't want to remove the old version?"
LangString OLD_WRONG_VER_REMOVE_FAILED ${LANG_ENGLISH} \
"FATAL: THE OLD UNINSTALLER FAILED. Once you click on OK the old version will remain on your PC and we will try to install the new version too. You can also press cancel and try to remove it on your own."
; Abort the installer/uninstaller if Jamulus is running
!macro _AbortOnRunningApp

Expand All @@ -93,7 +100,6 @@ LangString RUNNING_APP_MSG ${LANG_ENGLISH} \

; Installer
!macro InstallApplication buildArch

!define prefix "${DEPLOY_PATH}\${buildArch}"
!tempfile files

Expand Down Expand Up @@ -181,8 +187,27 @@ Function .onInit
ReadRegStr $INSTDIR HKLM "${APP_INSTALL_KEY}" "${APP_INSTALL_VALUE}"
IfErrors 0 +2
StrCpy $INSTDIR "$PROGRAMFILES64\${APP_NAME}"

${Else}

; check if old, wrongly installed jamulus exists. See https://stackoverflow.com/questions/27839860/nsis-check-if-registry-key-value-exists#27841158
IfFileExists "$PROGRAMFILES32\Jamulus\Uninstall.exe" wrong_install_found continueinstall

wrong_install_found:
MessageBox MB_YESNOCANCEL|MB_ICONEXCLAMATION "$(OLD_WRONG_VER_FOUND)" /sd IDYES IDNO idontcare IDCANCEL quit
goto removeold
idontcare:
MessageBox MB_YESNO|MB_ICONEXCLAMATION "$(OLD_WRONG_VER_FOUND_CONFIRM)" /sd IDNO IDYES continueinstall
goto removeold
removeold:
ExecWait "$PROGRAMFILES32\Jamulus\Uninstall.exe" $0
${IfNot} $0 == 0
MessageBox MB_OKCANCEL|MB_ICONEXCLAMATION "$(OLD_WRONG_VER_REMOVE_FAILED)" /sd IDCANCEL IDOK continueinstall
goto quit
${EndIf}
goto continueinstall
quit:
Abort
continueinstall:
${Else}
SetRegView 32
SectionSetFlags ${Install_x86} ${SF_SELECTED}
SectionSetFlags ${Install_x86_64} ${SECTION_OFF}
Expand All @@ -193,13 +218,11 @@ Function .onInit
StrCpy $INSTDIR "$PROGRAMFILES32\${APP_NAME}"

${EndIf}

; Install for all users
SetShellVarContext all

; Select installer language
!insertmacro MUI_LANGDLL_DISPLAY

FunctionEnd

; Ensure Jamulus is installed into a new folder only, unless Jamulus is already installed there
Expand Down Expand Up @@ -250,7 +273,6 @@ FunctionEnd
!macroend

Section "un.Install"

; Delete the main application
${If} ${RunningX64}
!insertmacro un.InstallFiles x86_64
Expand Down