Skip to content

Remember if user selected the desktop icon on last install#845

Merged
corrados merged 2 commits intojamulussoftware:improve_win_cifrom
ann0see:addChoices
Jan 16, 2021
Merged

Remember if user selected the desktop icon on last install#845
corrados merged 2 commits intojamulussoftware:improve_win_cifrom
ann0see:addChoices

Conversation

@ann0see
Copy link
Copy Markdown
Member

@ann0see ann0see commented Jan 15, 2021

@pljones

The installer now remembers if you selected/didn't select the creation of a desktop icon.

Do we also need to remember if the user selected to run the app or skipped the ASIO check?

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 15, 2021

This should be tested by corrados and pjones before it gets merged. Not 100% sure if everything works as expected from you.

@corrados
Copy link
Copy Markdown
Contributor

Let's merge it. You have done so many changes to the installer. After everything is ready, we have to do a lot of testing anyway.

@corrados
Copy link
Copy Markdown
Contributor

I just saw the following: You have changed the following files:
src/res/jamulus-icon-uninstall-2020.psd
windows/uninstaller-welcome.bmp
windows/uninsticon.ico

Was this indended? Do you overwrite the files from GeheimerEichkater? Maybe this is a merge issue. Please check.

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 16, 2021

Yes. This is intended. Sorry I forgot to mention this: since the installer and uninstaller both use the same images, I removed the duplicate uninstall welcome icon and tell the installer to use the same one for uninstalling. Also since the uninst icon doesn't get shown, I removed it.

Edit: the uninst Icon was created by me.

@corrados corrados merged commit 236d746 into jamulussoftware:improve_win_ci Jan 16, 2021
@ann0see ann0see mentioned this pull request Jan 16, 2021
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants