Automated build by nefarius2001 · Pull Request #855 · jamulussoftware/jamulus

nefarius2001 · 2021-01-18T01:47:26Z

Resolves; #854 & #835
Also relates to: #853
intentionally not solving #856 & #857
Credit and thanks to @ann0see for contributing & support

!! DO NOT MERGE YET !!!
this pull request is for preview & discussion
please do not merge until @ann0see and I sorted out Windows & Android builds both working :)

…ging to productive)

…d_android_build

ann0see · 2021-01-18T06:20:05Z

I will look into it later ;-).

Windows support (see my PR). Can you move your Android scripts to /android?

corrados · 2021-01-18T06:42:17Z

 ![CodeQL](https://github.com/corrados/jamulus/workflows/CodeQL/badge.svg)

-Jamulus - Internet Jam Session Software
+Jamulus - Internet Jam Session Software  


Why is that?

To generate new commits and trigger the ci...
Please ignore/ revert that!

You should probably ensure that you trigger it differently and open a new PR with only working commits.

nefarius2001 · 2021-01-18T08:48:34Z

moved build to a subdirectory of "android" for consistency with current structure.
Not perfect consistent, but I would still splitting source code and build scripts for different os ( #856 ).

ann0see

Some comments

ann0see · 2021-01-18T09:15:00Z

  push:
    tags:
-      - "r*" # run this action if a tag beginning with r is created
-  workflow_dispatch:


Not sure if we should allow workflow_dispatch (for me it didn't always work)

ann0see · 2021-01-18T09:15:44Z

@@ -0,0 +1,39 @@
+#!/usr/bin/python3


Python. Interesting. So you get some information from the current build/tag which triggered this?

yes.
Easier string manipulations like startsWith.

ann0see · 2021-01-18T09:15:55Z

+release_version_name = jamulus_version
+
+if fullref.startswith("refs/tags/"):
+    print('python is Tag')


Is this a debugging output?

yes, changed to a more meaningful text

ann0see · 2021-01-18T09:16:55Z

+PUSHED_NAME=${GITHUB_REF#refs/*/}
+
+# calculate various variables
+python3 ${1}/.github/actions_scripts/analyse_git_reference.py ${GITHUB_REF} ${PUSHED_NAME} ${JAMULUS_VERSION} 


Would it be possible to also get the Jamulus version and Tag via python? this would be much cleaner.

possible, but more part of #854 optimizations.

ann0see · 2021-01-18T09:18:06Z

-jobs:
-
-  ## Creates the releases on GitHub ##
+jobs: 


You've changed a lot and I still have to look through it. But it seems to work. Would it be possible that you add the same comments as I did?

done bf47be2

at lease I did my best, feel free to adjust them to your needs

ann0see · 2021-01-18T09:19:44Z

        run:                        sh linux/autorelease_linux.sh ${{ github.workspace }}
-        if:                         matrix.config.os == 'ubuntu-18.04'
+        if:                         matrix.config.target_os == 'linux'
      - name:                       "Build (Windows)"


Should be removed and synced to my changes.

how? please make a suggestion

If you've removed the Install Qt steps (I think this is now the case) and run my script autobuild_windows.ps1 this is solved. I think this PR is no longer up to date.

ann0see · 2021-01-18T09:20:55Z

 ![CodeQL](https://github.com/corrados/jamulus/workflows/CodeQL/badge.svg)

-Jamulus - Internet Jam Session Software
+Jamulus - Internet Jam Session Software  


You should probably ensure that you trigger it differently and open a new PR with only working commits.

ann0see · 2021-01-18T09:21:41Z

@@ -0,0 +1,82 @@
+FROM ubuntu:18.04


Can't say much from here on (I don't know android building and docker)

ann0see · 2021-01-18T09:22:28Z

+
+# Download / install Qt
+####ADD https://code.qt.io/cgit/qbs/qbs.git/plain/scripts/install-qt.sh ./
+COPY install-qt.sh /install-qt.sh


Install-qt.sh that's interesting.

Mmmm. We do need to sort this out so we've a build script (that just gets the pre-reqs and does the qmake-make) per platform so it's re-usable - then the packaging and code analysis can both use it as they see fit.

that is likely possible.
Though I also see some benefits in using a docker.
Maybe splitting in "installing qt and pre-reqs" and "qmake-make" can be done, to allow caching of the first step?

ann0see · 2021-01-18T09:23:16Z

@@ -0,0 +1,339 @@
+#!/usr/bin/env bash


Can you also use aqt to install qt? This script looks quite complicated to me.

I tried copying your aqt method to the CodeQL workflow... without success. Maybe a bad dependency...

Don't know. I was really happy to have something working.
make it work, make it fast, make it clean...

Strange. For me, it worked. Maybe the server is down? At least it says something like this in the CodeQl action at the moment.

Yes. It seems to be down: https://forum.qt.io/topic/122837/download-qt-io-is-down

ann0see · 2021-01-18T13:29:43Z

+# calculate various variables
+python3 ${1}/.github/actions_scripts/analyse_git_reference.py ${GITHUB_REF} ${PUSHED_NAME} ${JAMULUS_VERSION} 
+
 perl ${1}/.github/actions_scripts/getChangelog.pl ${1}/ChangeLog ${VERSION} > ${1}/autoLatestChangelog.md


You will have to rename ${VERSION} to ${JAMULUS_VERSION} if you also renamed the variable above.

Also Codacy complained about missing quotes. We might need to add them around the variables/file paths.

thanks.
Where can i see these complaints when I develop something?

You will not see them. I setup codacy on my repo only. You can just enable it if you create a codacy account (just google for it).

Sorry guys, I accidentally used the PR branch for development. I will open a new request soon.

nefarius2001 · 2021-01-19T12:06:38Z

Sorry guys, I accidentally used the PR branch for development. I will open a new request soon.

nefarius2001 added 10 commits January 17, 2021 00:40

trigger autobuild on branches for autobuild-development

890a3a1

for development only: tag by githash, not version (reverte before mer…

7c600d1

…ging to productive)

headless build as separate config

2f2fc9b

rename config.os

3303267

introduce config.target_os

39abc7f

add android build config

1b923bc

rework CI workflow (see jamulussoftware#854)

e220a20

Merge remote-tracking branch 'x_github_corrados/master' into automate…

bdf4b33

…d_android_build

fix android build

50a7741

minor formatting

05441fc

nefarius2001 mentioned this pull request Jan 18, 2021

Automated build2 #858

Closed

corrados reviewed Jan 18, 2021

View reviewed changes

ann0see requested changes Jan 18, 2021

View reviewed changes

ann0see reviewed Jan 18, 2021

View reviewed changes

nefarius2001 closed this Jan 19, 2021

nefarius2001 deleted the automated_build branch January 24, 2021 03:29

Conversation

nefarius2001 commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ann0see commented Jan 18, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nefarius2001 commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pljones Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nefarius2001 commented Jan 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

nefarius2001 commented Jan 18, 2021 •

edited

Loading

nefarius2001 commented Jan 18, 2021 •

edited

Loading

pljones Jan 18, 2021 •

edited

Loading