Github Workflow CodeQL: Check out submodules

[hoffie]

(As noticed by @nefarius2001)

• Submodules are part of official releases, so it might make sense
  to run them through CodeQL as well.
• This is supposed to detect breakage with submodule inclusion
  as observed in submodule checkout broken #984.

Docs: https://github.com/actions/checkout

I'm not sure if the modified CodeQL workflow will already trigger in this PR (I suspect it won't). If it does, it will probably (correctly) fail until #985 is merged. It would be great if it did because I could then rebase and we could check if the action works as intended and passes afterwards.

Note: I have never worked with Github actions before so it might be horribly wrong what I do.

[hoffie]

I'm not sure if the modified CodeQL workflow will already trigger in this PR (I suspect it won't). If it does, it will probably (correctly) fail until #985 is merged. It would be great if it did because I could then rebase and we could check if the action works as intended and passes afterwards.

Seems like it works -- CodeQL fails in this PR because the new CodeQL workflow seems to be used:

  Error: fatal: clone of 'https://github.com/github.com/google/oboe.git' into submodule path '/home/runner/work/jamulus/jamulus/libs/oboe' failed
  Failed to clone 'libs/oboe' a second time, aborting
  Error: The process '/usr/bin/git' failed with exit code 1

I suggest waiting for #985 to be merged, will then rebase and then CodeQL should be green again.

[nefarius2001]

#978 is close to ready, will fix qodeql

[hoffie]

#978 is close to ready, will fix qodeql

Ah, thanks for the pointer. Your PR seems to move the CodeQL part to the autobuild which already contains a submodule-enabled checkout. So, after your PR my PR becomes irrelevant.

If your PR is merged quickly, I'll close my PR as it becomes obsolete. If there is still some back and forth I'd be in favor of merging my PR temporarily to spot any problems in this area.

[pljones]

Can this be closed?

[hoffie]

Yes, it will be part of #978 already.