Change bundle ID to app.jamulussoftware.*#1031
Merged
ann0see merged 1 commit intonext-releasefrom Sep 1, 2024
Merged
Conversation
ann0see
changed the title
ann0see
commented
Sep 1, 2024
ann0see
force-pushed
the
macOS/changeBundleId
branch
from
f5f02d8 to
e9d9d5f
Compare
ann0see
force-pushed
the
macOS/changeBundleId
branch
from
e9d9d5f to
df6a8b6
Compare
ann0see
commented
Sep 1, 2024
Member
Author
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Self review looks ok, but still please check for oddities.
ann0see
changed the title
pljones
reviewed
Sep 1, 2024
| **Note for macOS users:** As of Jamulus 3.8.1, we have a signed installer. This will store the settings in | ||
| ```shell | ||
| $HOME/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/ | ||
| $HOME/Library/Containers/app.jamulussoftware.Jamulus/Data/.config/Jamulus/ |
Contributor
There was a problem hiding this comment.
Should this be marked "no translate" in some way?
pljones
reviewed
Sep 1, 2024
| "**Hinweis für macOS-Nutzer:** Ab Jamulus 3.8.1 gibt es ein signiertes Installationsprogramm. Dieser speichert die Einstellungen in\n" | ||
| "```shell\n" | ||
| "$HOME/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/\n" | ||
| "$HOME/Library/Containers/app.jamulussoftware.Jamulus/Data/.config/Jamulus/\n" |
Contributor
There was a problem hiding this comment.
These three copies appear to be duplicates (lines 801 through 820 need cleaning up).
Member
Author
There was a problem hiding this comment.
I think it’s translation memory. We could clean it but there’s no need.
Contributor
|
Nothing blocking. |
pljones
approved these changes
Sep 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Changes the server and client bundle id to
app.jamulussoftware.*Context: Fixes an issue? Related issues
Fixes: #1029
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review and potential translation fixes
Does this need translation?
YES, but all translations have been replaced.
Checklist