-
Notifications
You must be signed in to change notification settings - Fork 92
Update CONTRIBUTING files #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ac8103d
Add new contributing file
ann0see 02bdee1
Clarify branches
ann0see 2077a3b
Moved a bit to homepage
ann0see 488bb9d
Review updates
ann0see ff94461
fix typo
ann0see c56881b
Grammar
ann0see 957e2cf
Add more translation services
ann0see 1cfcfc5
Merge branch 'changes' into upd_contribute
ann0see 7852747
fix a few issues
ann0see 3c2662c
small fix
ann0see 9018865
Add github
ann0see 5a5d6c7
Update README
ann0see 7b419bc
@ignotus666 changes
ann0see 959f85e
Wording
ann0see 024a886
ignotus rechnet
ann0see 51b4a58
gilgongo fix
ann0see 16720da
Update CONTRIBUTING.md
ann0see eb34e7d
Update README.md
ann0see 6cda430
Update README.md
ann0see 4374bb5
Update README.md
ann0see File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,41 @@ | ||
| # Contribute | ||
| # Contribute to the documentation | ||
| We really appreciate your support! | ||
|
|
||
| Thanks for your support! | ||
| Please open an issue on github. More to come soon... | ||
| ~~Please open a pull request on GitHub!~~ | ||
| Please note that discussions should be kept in English. If you don't speak English fluently you can use a reasonably good online translator (e.g. [DeepL](https://www.deepl.com), [Reverso](https://www.reverso.net/text_translation.aspx), ...) which might be able to translate your language to English. | ||
|
|
||
| Please have a look at the [issues page on GitHub](https://github.com/jamulussoftware/jamuluswebsite/issues) and check if anybody has raised an issue with the same topic. | ||
|
|
||
| If this is the case, please subscribe to the issue and explain your proposal. | ||
|
|
||
| If that's not the case, please open a [new issue](https://github.com/jamulussoftware/jamuluswebsite/issues/new/choose), select which type of issue it is and describe your issue. | ||
|
|
||
| If you want to open a Pull Request (after having described and discussed your proposal), keep in mind that your changes (if they are not just typos) might have to wait until everything is translated. We will bundle them (if everything is all right) with any other changes and upload all of them as a combined Pull Request to jamulus.io. | ||
|
|
||
| Pull requests/issues for the website should have a title which looks like this: | ||
|
|
||
| `[Tag (like Bug, Translation, etc.)][language code (e.g. en)] {short description of your changes}` | ||
|
|
||
| ## Branches, Translation and development process | ||
|
|
||
| We currently use *multiple branches* to ensure that translators know what to translate. | ||
|
|
||
| After having discussed and agreed on changes you want to be integrated to jamulus.io, you should ask yourself some questions: | ||
|
|
||
| ## 0. Is your content in a language that already exists on the site? | ||
| If not: This will be discussed this later (since you introduce a new language). | ||
| If so look here: | ||
| ### 1. Be clear if your change needs translation | ||
| **No:** A fix which doesn't need to be translated (e.g. typo) --> Open a Pull Request to `release`. It will go live a few minutes after the PR is merged | ||
| **Yes:** A fix which needs to be translated (e.g. if you want to make a sentence or paragraph clearer) --> Commit to `changes` since others will need to translate it. It will be part of the next release. | ||
|
|
||
| ### 2. Be clear if a translation update is going on | ||
| You can see this if we ping the translators in a PR from changes to translate. | ||
|
|
||
| **If yes:** only translate the changes of the Pull Request from changes to translation. If you find issues, start with 1 | ||
| **If no:** no need to care about the translate branch | ||
|
|
||
| ## Adding a new language | ||
|
|
||
| 1. Open an issue with the title [Translate] `yourLanguage` and say that you want to translate the homepage into your language. | ||
| 2. If you start your new translation, follow the instructions to add a new language in the /README.md file on the changes branch. | ||
| 3. Finally, open a PR to `translate` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,44 @@ | ||
| # Jamulus Website | ||
|
|
||
| This is the home of the [Jamulus website](https://jamulus.io) and wiki. | ||
|
|
||
| ## Tech | ||
|
|
||
| Built with Jekyll and Fox-CSS | ||
|
|
||
| ## Contribute and translation | ||
|
|
||
| Do you want to contribute to the Jamulus Wiki/Website? Please open an issue since we're currently discussing how to fasciliate contribution. ~~See the [CONTRIBUTING.md](CONTRIBUTING.md) file and the [contributing wiki entry](https://jamulus.io/wiki/Contribution).~~ | ||
| This is the home of the [Jamulus website](https://jamulus.io). The goal of this page is to explain what Jamulus is and how to use it. | ||
|
|
||
| ## Adding pictures | ||
| Unfortunately GitHub doesn't enable picture upload on the normal md editor. Therefore you can attempt to open an issue, upload your image, copy the link to the page you want to integrate it into and then don't submit the issue. See this answer on stack overflow: https://stackoverflow.com/a/26601810 | ||
|
|
||
| ## Translating | ||
| ## Contribute a translation | ||
|
|
||
| Translations are handled by the [Polyglot jekyll Plug-in](https://github.com/untra/polyglot). | ||
| **Before translating, please have a look at the [CONTRIBUTING.md](CONTRIBUTING.md) file to get familiar with our translation process. Afterwards, check if there's already a discussion thread for your language here: https://github.com/jamulussoftware/jamuluswebsite/discussions and participate in it** | ||
|
|
||
| Translations are handled by the [Polyglot Jekyll Plug-in](https://github.com/untra/polyglot). | ||
| If you want to translate a file, you must first know where it is located on this repo: | ||
|
|
||
| - General translations especially for the wiki can be found in \_includes/wiki/yourlanguagecode folder. These files **must** be translated in order not to break the site. | ||
| - The homepage is located in the repo root and named [langcode]-index.html | ||
| - General translations (especially for the wiki) can be found in \_includes/wiki/yourlanguagecode folder. These files **must** be translated in order not to break the site. | ||
| - The homepage (https://jamulus.io/) is located in the repo root and named 1-[langcode]-index.html | ||
| - The wiki content can be found in the wiki/ folder. Make sure to read the README.md file in the wiki/ folder. | ||
| - The navigation and general translations can be found in the \_data/yourlanguagecode folder | ||
|
|
||
|
|
||
| To translate a file, please duplicate it and change the `lang:` attribute to the language you want to translate it to. If you want to translate an English page to German, you need to change the `lang: "en"` attribute to `lang: "de"`. This attribute can be found at the top of the file in the front matter (right at the top in between the `---`). Do not change the permalink attribute. It links pages with the same content but different languages and enables polyglot to know which page to change to if you change the language via the language picker. | ||
| To translate a file, please duplicate it and change the `lang:` attribute to the language you want to translate it to. If you want to translate an English page to German, you need to change the `lang: "en"` attribute to `lang: "de"`. This attribute can be found at the top of the file in the front matter (right at the top in between the `---`). Do not change the permalink attribute (It internally links pages with the same content but different languages and enables polyglot to know which page to change to if you change the language via the language picker.) | ||
|
|
||
| ### Adding a new language | ||
|
|
||
| If you want to add a new language, you must follow the instructions on the polyglot site and add the folders/files. | ||
| - Make sure to add your language to the \_config.yml file (in the languages array.) | ||
| - At least, the main includes for the wiki (see \_includes/wiki/) have to be translated. | ||
| - The navigation and general site wide strings (see the \_data/ folder) and the homepage (see the 1-index.html file in the root of this repo) should be translated. | ||
| - The navigation and general site-wide strings (see the \_data/ folder) and the homepage (see the 1-index.html file in the root of this repo) should be translated. | ||
|
|
||
| Have a look at the README.md files in these folders. | ||
|
|
||
| ## Tech | ||
|
|
||
| This site is built with Jekyll and Fox-CSS. | ||
|
|
||
| ## Contribute to the design/site structure | ||
| Please open an issue and see the [CONTRIBUTING.md](CONTRIBUTING.md) file. | ||
|
|
||
| Since this page uses Jekyll, please have a look at the [jekyll documentation](https://jekyllrb.com/docs/). | ||
| This project uses the fox css framework. See the [FOX-CSS documentation](http://www.fox-css.com/documents/). | ||
| ### A few tips/links | ||
| Since this page uses Jekyll, please have a look at the [Jekyll documentation](https://jekyllrb.com/docs/). | ||
| This project uses the FOX-CSS framework. See the [FOX-CSS documentation](http://www.fox-css.com/documents/). | ||
| CSS files can be found in the assets/css folder. | ||
| The \_layouts folder holds the main layouts for the page. | ||
| More information can be found at the README.md files in (almost) every folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is clear now. We might need to clarify our process.