Explain how the new installer can be compiled#233
Conversation
This will show how to compile the new installer on Windows. Have a look at the discussion in jamulussoftware/jamulus#792
|
Oh, I just saw this. I made some updates to this page based on my experience too. Let's combine! |
|
So we have two conflicting PRs on this issue now ;-). #234 and this one. Can you transfer my changes to your pr or should I transfer yours here? |
Add more detail for the Windows build process
|
@jdrage Ok. I've now merged your changes into this PR. I suggest to continue discussion here. |
|
This is now ready for review. |
|
@ann0see ok, I should have time to have a look to it tomorrow |
|
Great! You can also have a look at the other PRs |
There was a problem hiding this comment.
Seems to be missing a bunch of full stop at the end of lines, unless we avoid those across all the website pages. Not sure.
LGTM overall.
Great! You can also have a look at the other PRs
Yes, I know! Only have a limited free time at my disposal unfortunately. So unless someone want to finance me working on that, I'm trying to do a bit everyday when/where I can. I hope it is still useful.
| * Use the free GPLv2 license for Open Source development | ||
| * To determine the Qt version you need, check [qt-installer-windows.qs](https://github.com/corrados/jamulus/blob/master/windows/qt-installer-windows.qs): under INSTALL_COMPONENTS you will see `qt.qt5.[version]`, e.g., 5123 means version 5.12.3. | ||
| * Select Components during installation: Expand the Qt section, find the matching version, e.g., **Qt 5.12.3**, and add the compiler components for your compiler, e.g., `MSVC 2017 32-bit/64-bit` for Visual Studio 2019 | ||
| * [ASIO development files](https://www.steinberg.net/de/company/developer.html) |
There was a problem hiding this comment.
Would be better for our Jamulus English page to link to the English Steinberg page: https://www.steinberg.net/en/company/developers.html
|
|
||
| 1. Open PowerShell | ||
| 1. Navigate to the `jamulus` directory | ||
| 1. To allow unsigned scripts, run `Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser`. You can also revert this after having run this script. For more information see the [Microsoft PowerShell documentation page](https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-executionpolicy) |
There was a problem hiding this comment.
Missing a full stop at the end of the sentence.
| 1. To allow unsigned scripts, run `Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser`. You can also revert this after having run this script. For more information see the [Microsoft PowerShell documentation page](https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-executionpolicy) | ||
| 1. Edit the $QtCompile32 and $QtCompile64 variables | ||
| 1. Run the Jamulus compilation and installer script: `.\windows\deploy_windows.ps1 C:\Qt\QtVersion`. | ||
| 1. You can now find the Jamulus installer in the `.\deploy` directory |
There was a problem hiding this comment.
Missing full stop at the end of all but one line here.
There was a problem hiding this comment.
I hope I haven't missed any.
…ebsite into newWinInstaller
|
👍 |
|
So I think we can merge this? |
This will show how to compile the new installer on Windows. Have a look at the discussion in jamulussoftware/jamulus#792