Skip to content

Explain how the new installer can be compiled#233

Merged
ann0see merged 12 commits intochangesfrom
newWinInstaller
Jan 22, 2021
Merged

Explain how the new installer can be compiled#233
ann0see merged 12 commits intochangesfrom
newWinInstaller

Conversation

@ann0see
Copy link
Copy Markdown
Member

@ann0see ann0see commented Jan 5, 2021

This will show how to compile the new installer on Windows. Have a look at the discussion in jamulussoftware/jamulus#792

This will show how to compile the new installer on Windows. Have a look at the discussion in jamulussoftware/jamulus#792
@ann0see ann0see self-assigned this Jan 5, 2021
@ann0see ann0see requested a review from corrados January 5, 2021 19:40
@jdrage
Copy link
Copy Markdown
Contributor

jdrage commented Jan 6, 2021

Oh, I just saw this. I made some updates to this page based on my experience too. Let's combine!

Comment thread wiki/en/en-Compiling.md Outdated
Comment thread wiki/en/en-Compiling.md Outdated
Comment thread wiki/en/en-Compiling.md
@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 6, 2021

So we have two conflicting PRs on this issue now ;-). #234 and this one. Can you transfer my changes to your pr or should I transfer yours here?

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 6, 2021

@jdrage Ok. I've now merged your changes into this PR. I suggest to continue discussion here.

@ann0see ann0see marked this pull request as ready for review January 18, 2021 12:38
@ann0see ann0see requested review from gilgongo and trebmuh January 18, 2021 12:47
@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 18, 2021

This is now ready for review.

@trebmuh
Copy link
Copy Markdown
Member

trebmuh commented Jan 18, 2021

@ann0see ok, I should have time to have a look to it tomorrow

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 18, 2021

Great! You can also have a look at the other PRs

Copy link
Copy Markdown
Member

@trebmuh trebmuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be missing a bunch of full stop at the end of lines, unless we avoid those across all the website pages. Not sure.

LGTM overall.


Great! You can also have a look at the other PRs

Yes, I know! Only have a limited free time at my disposal unfortunately. So unless someone want to finance me working on that, I'm trying to do a bit everyday when/where I can. I hope it is still useful.

Comment thread wiki/en/en-Compiling.md Outdated
* Use the free GPLv2 license for Open Source development
* To determine the Qt version you need, check [qt-installer-windows.qs](https://github.com/corrados/jamulus/blob/master/windows/qt-installer-windows.qs): under INSTALL_COMPONENTS you will see `qt.qt5.[version]`, e.g., 5123 means version 5.12.3.
* Select Components during installation: Expand the Qt section, find the matching version, e.g., **Qt 5.12.3**, and add the compiler components for your compiler, e.g., `MSVC 2017 32-bit/64-bit` for Visual Studio 2019
* [ASIO development files](https://www.steinberg.net/de/company/developer.html)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better for our Jamulus English page to link to the English Steinberg page: https://www.steinberg.net/en/company/developers.html

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fixed

Comment thread wiki/en/en-Compiling.md Outdated

1. Open PowerShell
1. Navigate to the `jamulus` directory
1. To allow unsigned scripts, run `Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser`. You can also revert this after having run this script. For more information see the [Microsoft PowerShell documentation page](https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-executionpolicy)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a full stop at the end of the sentence.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread wiki/en/en-Compiling.md Outdated
1. To allow unsigned scripts, run `Set-ExecutionPolicy -ExecutionPolicy RemoteSigned -Scope CurrentUser`. You can also revert this after having run this script. For more information see the [Microsoft PowerShell documentation page](https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-executionpolicy)
1. Edit the $QtCompile32 and $QtCompile64 variables
1. Run the Jamulus compilation and installer script: `.\windows\deploy_windows.ps1 C:\Qt\QtVersion`.
1. You can now find the Jamulus installer in the `.\deploy` directory
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full stop at the end of all but one line here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I haven't missed any.

@trebmuh
Copy link
Copy Markdown
Member

trebmuh commented Jan 20, 2021

👍

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented Jan 20, 2021

So I think we can merge this?

@ann0see ann0see merged commit 2354ebd into changes Jan 22, 2021
@ann0see ann0see deleted the newWinInstaller branch January 22, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants