Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't
aqtinstallwork for Qt on Fedora (and most platforms (edit)maybe(/edit) except Windows)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only searched for a replacement package in Fedora's standard repos.
aqtinstallseems not to be in there, butqt5-qtbaseis.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it for the MacOS build -- I wondered if it would save platform-specifics having to be written for the other platforms but it seems the autobuild is very platform specific still...
https://github.com/jamulussoftware/jamulus/blob/master/autobuild/mac/artifacts/autobuild_mac_1_prepare.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment regarding Mac, but I don't think we should require additional packets or scripts (?) on Linux where dependencies can be installed by the native package managers (apt, dnf, yum, etc.). At least it should be like this for users building from source and distributors. As such, it would be the best check for us to do the same in autobuild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always thought
aqtinstallwas just a way of being able to install a specific version of Qt into a build environment for Mac only, so that the installation package produced would contain the version of Qt runtimes required for backward compatibility. For Fedora/CentOS/Debian/Ubuntu, there is no need foraqtinstall, because we just use the packaged version of Qt provided by the distro.