Merged
Conversation
ann0see
approved these changes
Jul 10, 2022
ann0see
reviewed
Jul 10, 2022
|
|
||
| ### Audio Alerts | ||
|
|
||
| This turns on a sound alert for when someone joins a chat, or when receiving a new chat message. |
Member
There was a problem hiding this comment.
It also gives a message if someone joins and doesn't send a chat
Member
Author
There was a problem hiding this comment.
I think that's implied, no?
Member
There was a problem hiding this comment.
I think he means that there's an alert when someone joins a server, not a chat. Then there's another alert for new chat messages.
Member
Author
There was a problem hiding this comment.
Oh - I didn't realise the audio alert was for server joining too. I better amend that wording then.
Member
Author
There was a problem hiding this comment.
So the audio alert plays when EITHER somebody joins a Server, OR when somebody sends a new chat message, is that right?
Member
There was a problem hiding this comment.
As far as I know, yes, with a different sound for each event.
ann0see
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
jamulussoftware/jamulus#2640 - sound alert
jamulussoftware/jamulus#2199 - screenshot (also 2424)
(I looked at jamulussoftware/jamulus#2673 but the website seems fine)