Conversation
… button, as well as corresponding test. Components are passed copy of stored state, and they pass registerFinalState() to Model on unmount. All tests passing, though I rolled back some tests because they failed on refactor. Added some functionality to ExTab as an example of updating state and a button. Also updated the README.
ddibened
requested review from
adinajohnson,
emmitheunicorn,
janeon and
svouse
Collaborator
Author
|
important note: the tree doesn't yet pass down the 'registerFinalState' function all the way to the components (by which I mean tabs), it stops in the 'props' of TabDisplay, because I haven't thoroughly tested it yet, but I don't think we are at the point where we are testing persistent state yet, so it shouldn't be a problem :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More succinct model, as well as updates to README and ExTab (it now has a button and state), I think this will be helpful for your Saturday code session, so please pull first :) (it shouldn't change anything you have written on your own.