forked from scientific-software-reviewers/tutorial
-
Notifications
You must be signed in to change notification settings - Fork 0
Exercise 2 python. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
python-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,10 @@ class TimeWindow: | |
| """ Observations for a TIEGCM experiment """ | ||
|
|
||
| def __init__(self, start_time, end_time, delta): | ||
| """ Initializes the observations associated with a TIEGCM experiment | ||
| """ Initialize the window and model times associated with a TIEGCM experiment | ||
|
|
||
| start_time - string '%Y-%m-%d %H:%M:%S' model start time of experiment | ||
| end_time - string '%Y-%m-%d %H:%M:%S' model end time of experiment | ||
| start_time - string '%Y-%m-%d %H:%M:%S' model inital time | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is a typo in inital (should be initial) |
||
| end_time - string '%Y-%m-%d %H:%M:%S' model end time | ||
| delta - integer assimilation window time in hours | ||
|
|
||
| model_time is the center of the window. | ||
|
|
@@ -20,12 +20,20 @@ def __init__(self, start_time, end_time, delta): | |
|
|
||
| """ | ||
|
|
||
| # Error checking of delta input | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it would be good to add documentation indicating why these numbers were added for the conditions |
||
| if delta > 23: | ||
| raise ValueError("invalid delta {} should be [0-23] hours".format(delta)) | ||
|
|
||
|
|
||
| if delta < 0: | ||
| raise ValueError("invalid delta {} should be [0-23] hours".format(delta)) | ||
|
|
||
| if delta == 0: | ||
| raise ValueError("invalid delta {} cannot be exactly 0 hours".format(delta)) | ||
|
|
||
|
|
||
| self.start_time = datetime.strptime(start_time, '%Y-%m-%d %H:%M:%S') | ||
| self.end_time = datetime.strptime(end_time, '%Y-%m-%d %H:%M:%S') | ||
| self.delta = abs(delta) | ||
| self.delta = delta | ||
| self.delta_half = delta / 2 | ||
|
|
||
| # create a list of times for the experiment | ||
|
|
@@ -44,6 +52,8 @@ def __init__(self, start_time, end_time, delta): | |
|
|
||
| def info(self): | ||
|
|
||
| """ prints first and last window times """ | ||
|
|
||
| print("win num_cycles", self.num_cycles) | ||
|
|
||
| if self.num_cycles > 0: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to clarify what TIEGCM means