Py3 #13
Open
Py3 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the segmenation fault caused by config_parser is being ignored by removing the contrib directory for now. By ignoring this for now, we can at least see how many tests are failing, and work on those. I got the number of passing tests to increase by fixingh an encoding error.
down to 55 tests failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, I removed the contrib directory from the tests just to work on the other errors. I worked on a few encoding issues and I was able to get from 150 test failing to only 55 tests failing. Once we get these tests passing, we can look at the contrib tests again.