Pin System.Security.Cryptography.Xml to fix GHSA-37gx-xxp4-5rgx#197
Merged
Pin System.Security.Cryptography.Xml to fix GHSA-37gx-xxp4-5rgx#197
Conversation
Pin the transitive dependency System.Security.Cryptography.Xml to 10.0.7 via CentralPackageTransitivePinningEnabled, replacing the vulnerable 8.0.2 version.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Pins a vulnerable transitive NuGet dependency (System.Security.Cryptography.Xml) at the repo level to eliminate the NU1903 security audit warning (GHSA-37gx-xxp4-5rgx) across the solution when using Central Package Management + transitive pinning.
Changes:
- Add a centralized transitive pin for
System.Security.Cryptography.Xmlto version10.0.7. - Document the reason for the pin inline in
Directory.Packages.props.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1118 1118
Lines 66302 66302
Branches 8767 8767
=====================================
Misses 66302 66302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.Security.Cryptography.Xml8.0.2 is affected by GHSA-37gx-xxp4-5rgx (high severity)CentralPackageTransitivePinningEnabledset totrueinDirectory.Build.props, adding aPackageVersionentry pins the resolved version across all projectsTreatWarningsAsErrorswhereNoWarndoes not inherit properly fromDirectory.Build.propsTest plan
dotnet list package --include-transitive --vulnerableno longer reports System.Security.Cryptography.XmlSummary by cubic
Pin
System.Security.Cryptography.Xmlto 10.0.7 to fix GHSA-37gx-xxp4-5rgx present in 8.0.2. This also clears NU1903 vulnerability warnings that can fail CI withTreatWarningsAsErrors.Written for commit 5cd7e57. Summary will update on new commits.