Fix the browser compiler crashing on extended characters in script blocks#4375
Merged
GeoffreyBooth merged 1 commit intojashkenas:masterfrom Nov 28, 2016
Merged
Conversation
…it is UTF-16 like the contents of a <script> block generally are
lydell
approved these changes
Nov 28, 2016
Owner
|
Super gross hack! But nice save! |
Merged
EsrefDurna
pushed a commit
to EsrefDurna/coffeescript
that referenced
this pull request
Nov 12, 2025
…it is UTF-16 like the contents of a <script> block generally are (jashkenas#4375)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4263, which is rather important because
test/test.htmlhas Japanese characters in a comment and therefore it doesn’t actually run in a browser without this fix 😄