Merged
Conversation
…ll CoffeeScript the non-NPM way
…ollowing the same form
…nless it’s explicitly excluded
lydell
reviewed
Feb 15, 2017
| releaseHeader('2017-02-15', '1.12.4', '1.12.3') | ||
| ``` | ||
|
|
||
| * The `cake` commands have been updated, with new `watch` options for most tasks. Clone the [CoffeeScript repo](https://github.com/jashkenas/coffeescript) and run `cake` at the root of the repo to see the options. |
Collaborator
There was a problem hiding this comment.
As someone who has worked on the CoffeeScript source code, this is easily the most exciting part of the changelog. But do "regular users" even care? I'm not sure that we should mention the changes to CoffeeScript's internal Cakefile here – might just be confusing?
Collaborator
Author
There was a problem hiding this comment.
I agree. I thought it was worth mentioning because the docs mentioned the cake commands, though I've been removing those references. They're still mentioned all over the place in the wiki etc.
jashkenas
reviewed
Feb 15, 2017
Cakefile
Outdated
| fs.watch 'test/', | ||
| interval: 200 | ||
| recursive: yes | ||
| , (eventType, filename) -> |
Owner
There was a problem hiding this comment.
Naked leading comma is poor CoffeeScript style — wrap the object in braces.
Merged
Collaborator
Author
|
@lydell I think this should be ready to go. This would be the last release before 2.0.0-alpha1 🍾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the changelog:
cakecommands have been updated, with newwatchoptions for most tasks. Clone the CoffeeScript repo and runcakeat the root of the repo to see the options.exporting a referenced variable was preventing the variable from being declared.coffeecommand wasn’t working for a.litcoffeefile.Includes #4440, assuming that will be merged in soon. If that requires more work, I’ll merge that branch into this one as needed.