Fix #4489: Regex octal escape sequence bug#4490
Merged
lydell merged 1 commit intojashkenas:masterfrom Apr 7, 2017
Merged
Conversation
Collaborator
|
Nice catch, and nice fix! 👍 |
This was referenced Apr 9, 2017
Merged
EsrefDurna
added a commit
to EsrefDurna/coffeescript
that referenced
this pull request
Nov 12, 2025
…escape_sequence_bug Fix jashkenas#4489: Regex octal escape sequence bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4489
Splits
INVALID_ESCAPEregex into separate regexesREGEX_INVALID_ESCAPE(which doesn't match back-references eg\1) andSTRING_INVALID_ESCAPE, thus avoiding the special-case logic for regex back-references (which contained the bug)