[WIP][CS2] Block comments in array literals#4541

Closed

GeoffreyBooth wants to merge 18 commits intojashkenas:2from

GeoffreyBooth:comment-block-in-array-literal

Commits on May 6, 2017

Comments tests should use same `toJS` function as the other tests
GeoffreyBooth
committed

Commits on May 7, 2017

Add simple multiline comment in array test
GeoffreyBooth
committed
Array grammar should mirror object grammar
GeoffreyBooth
committed
Multiline/block comments are now expressions, not statements, giving them parity with embedded JavaScript; no longer prepend a newline to block comments; make sure block comments still are output w…
GeoffreyBooth
committed
Block comments are no longer ignored in the ‘directive prologue’, so you’ll need to find another solution if you need a comment above ‘use strict’
GeoffreyBooth
committed
Block comments are no longer statements, so an empty conditional no longer evaluates into empty braces; this is just a breaking change, though it’s a bit ridiculous why someone would rely on block …
GeoffreyBooth
committed
Update tests for new output that lacks a preceding newline; add tests for block comments in array literals
GeoffreyBooth
committed
We should keep this test
GeoffreyBooth
committed
Now that block comments are expressions, `if` expressions need to output undefined if the if or else blocks are nothing but a block comment expression
GeoffreyBooth
committed
Block comment in an array shouldn’t be its own element
GeoffreyBooth
committed

Commits on May 8, 2017

Commits on May 9, 2017

Commits on May 14, 2017

Commits on May 18, 2017

Merge branch '2' into comment-block-in-array-literal
GeoffreyBooth
committed