Open
Conversation
This should allow building with JDK 13.
Upgrade to Gradle 6.0-rc-1 and BA Jlink 2.16.2
Create a new FXML-based view and controller that displays unsigned tx QR code to the left and scanning window for signed tx QR on the right. This is basically working, but UI is extremely raw.
Also disable separate “Scan” button (Still needs a lot more work)
This will have to do for now. More UI improvements will come later.
Compiles, runs, signs transactions, but Netwallet didn’t verify the transaction I tried to test. Needs testing and debugging…
(it currently can’t handle a version with -SNAPSHOT)
(They were not being run without this change)
* Fix a few test bugs * Reduce usage of LegacyAddress * Reduce hard-coded assumptions of TestNet3 * Reduce hard-coded assumptions of P2PKH outputScriptType
(For possible Gluon VM compatibility)
Also some Gradle cleanup: * Remove redundant definition of `jacksonVersion` * Use single quote for `moduleName` property name string * Use `archiveVersion` instead of deprecated `version` * Add `consensusj-signwallet-fx:jlink` to `buildCI` task
* Migrate JPackage download to gradle/downloadPackage.gradle * Use normalizeAppVersion() for jpackage in FX apps * This allows us to use a standard -SNAPSHOT version * Upgrade to Gradle 6.0 release version
(also remove extra semicolon in SignedResponseParser.java)
* Upgrade to latest B.A. Gradle JLink Plugin * Update jpackageBaseURL to use JDK 14 EA 34
* Add multiproject `buildJPackages` Gradle target * Add `signJPackageImages` flag in `gradle.properties` * Refactor jpackage build a little * Add documentation on how to manually verify signing
Also install binutils for the jlink command.
* JavaFX 14 * SupernautFX 0.0.6 * sourceCompatibility 11 in signwallet * BA JLink Plugin 2.17.2 * Groovy 3.0.2 * Spock 2.0-M2-groovy-3.0 * Jackson 2.10.2
(previously was 11 & 13)
also use transitive dependency to pull in Java Modularity plugin.
Also update some comments
JavaFX Plugin 0.0.8 doesn’t work with Module Plugin 1.6.0, so this commit is a test to see if 0.0.9-SNAPSHOT works. Looks good! But we’ll wait for 0.0.9 final before upgrading in `master` Upgrade to JavaFX Plugin 0.0.9, etc. * JavaFX Plugin to 0.0.9 * Pull Java Modularity plugin transitively in JavaFX modules * Java Modularity plugin to 1.7.0 in non-JavaFX modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.