Make it easier to test locally #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running locally with JDK-14+ results in a compilation error when running `ModulePluginSmokeTest` due to gradle/gradle#10248. Rather than requiring contributors to install _really_ old JDKs to run tests, lets provide an easy way to _locally_ comment out the old 5.x Gradle versions. The full version tests will still run on the build server. (This also makes it a lot easier to locally reduce the number of versions being tested during development)
Collaborator
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running locally with JDK-14+ results in a compilation error when running
ModulePluginSmokeTestdue to gradle/gradle#10248.Rather than requiring contributors to install really old JDKs to run tests, lets provide an easy way to locally comment out the old 5.x Gradle versions. The full version tests will still run on the build server.
(This also makes it a lot easier to locally reduce the number of versions being tested during development)