Avoid warning about --add-opens from compileTestJava task
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: java9-modularity#211 Avoids ``--add-opens has no effect at compile time` warnings when compiling test code by filtering out `--add-opens` entries from the `module-info.test` file when executing the `compileTestJava` task.
big-andy-coates
commented
Jul 24, 2022
| }); | ||
| } | ||
|
|
||
| @SuppressWarnings("Convert2Lambda") |
Collaborator
Author
There was a problem hiding this comment.
Added this to stop the use of code that can be converted to lambda, but which shouldn't be, showing up as a warning when compiling.
big-andy-coates
commented
Jul 24, 2022
| .ifPresent(this::configureTestJava); | ||
| } | ||
|
|
||
| @SuppressWarnings("Convert2Lambda") |
Collaborator
Author
There was a problem hiding this comment.
Added this to stop the use of code that can be converted to lambda, but which shouldn't be, showing up as a warning when compiling.
Collaborator
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #211
Avoids ``--add-opens has no effect at compile time
warnings when compiling test code by filtering out--add-opens` entries from the `module-info.test` file when executing the `compileTestJava` task.This is achieved by filtering out any
--add-openslines and the subsequent line, which contains the opens to add, in theModuleInfoTestHelperclass.