-
Notifications
You must be signed in to change notification settings - Fork 10
adding JDK9 module #1
base: master
Are you sure you want to change the base?
Conversation
LanceAndersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
Please update the readme to indicate:
-
the name of the module is java.transaction (like we did for JAF and common annotations)
-
javax.transaction.xa package is now part of the java.sql module and should be omitted going forward
bshannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the standalone (automatic) module include all the xa classes as well, so that you can override Java SE version of the module with a complete JTA module with all the JTA classes?
|
Need to change the spec version to 1.3. |
|
We will need to update this pull request to remove the javax.transaction.xa classes not just exclude them per the JTA 1.3 MR |
|
This pull request is no longer needed. |
No description provided.