Skip to content
This repository was archived by the owner on Aug 29, 2019. It is now read-only.

Conversation

@arindam-bandyopadhyay
Copy link
Member

No description provided.

Copy link

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Please update the readme to indicate:

  • the name of the module is java.transaction (like we did for JAF and common annotations)

  • javax.transaction.xa package is now part of the java.sql module and should be omitted going forward

Copy link
Member

@bshannon bshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the standalone (automatic) module include all the xa classes as well, so that you can override Java SE version of the module with a complete JTA module with all the JTA classes?

@ghost
Copy link

ghost commented Nov 13, 2017

Need to change the spec version to 1.3.
Need to change the jar version from 1.2.2-snapshot to 1.3-ea

@LanceAndersen
Copy link

We will need to update this pull request to remove the javax.transaction.xa classes not just exclude them per the JTA 1.3 MR

@ghost
Copy link

ghost commented Mar 13, 2018

This pull request is no longer needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants