Fix benchmark workflow: syntax error from stale code after avg_runs()#125
Merged
brunoborges merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow benchmark
Fix benchmark workflow: syntax error from stale code after avg_runs()
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
benchmark (macos-latest)job (and all OS variants) failed withsyntax error near unexpected token 'done'due to leftover lines from the oldavg_runs()body that were never removed when the function was rewritten to track failures.Root cause
When failure-tracking logic was added to
avg_runs(), the new function body was inserted correctly but the old closing lines were left orphaned immediately after:The bare
donewith no enclosing loop triggers an immediate syntax error, aborting the entire step.Fix
done,awk, and}) from theRun benchmarkstep in.github/workflows/benchmark.ymlOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.