Fix stream-toarray-typed: align metadata with filter+copy pattern in both approaches#146
Merged
brunoborges merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
…ilter+copy in both approaches Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com> Agent-Logs-Url: https://github.com/javaevolved/javaevolved.github.io/sessions/9eef2156-f7cf-4dac-8bb3-a3fb4be7c5e5
Copilot
AI
changed the title
[WIP] Fix stream-toArray behavior for typed conversion
Fix stream-toarray-typed: align metadata with filter+copy pattern in both approaches
Mar 25, 2026
brunoborges
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
oldApproachlabel and descriptive text described only typed array conversion, while the actual old code demonstrates filtering and copying — making the metadata inconsistent with the code.Changes
oldApproachlabel —"Manual Array Copy"→"Manual Filter + Copy"across English source and all 12 locale translation files (ar, bn, de, es, fr, it, ja, ko, pl, pt-BR, tr, zh-CN)summary— Updated to reflect the combined filter-then-collect-to-typed-array use caseexplanation— Rewritten to explain that streams eliminate the intermediateArrayListwhen chainingfilter()intotoArray(String[]::new)whyModernWins/ Concise entry — Now explicitly calls out the absence of an intermediate list: "No intermediate list — one expression replaces the manual loop and copy."The code itself (for-loop with filter +
toArray(new String[0])vsstream().filter().toArray(String[]::new)) was already a fair comparison and is unchanged.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.