🐞 Dice Roller activated although no formula given

[namtrah]

Check for existing bug reports before submitting.

• I searched for existing Bug Reports and found no similar reports.

Expected Behavior

I am creating a new layout in FS. In my system, abilities do not have scores, only the modifiers. So the stats[] array looks like stats[1,0,-2,3,1,0]. When I create a property to display the first stat, I am using a callback to look into the array. The code looks like this:

{
  "type": "property",
  "id": "6a68eab8abaa",
  "properties": [
    ""
  ],
  "fallback": "-",
  "display": "S",
  "callback": "console.log(\"Stats[0]\" + monster.stats[0])\nreturn monster.stats[0];",
  "diceCallback": ""
},

The output shows only the console.log, but the stat errors with two dice roller messages 1) "Invalid syntax at line 1" and 2) "Could not parse".

A workaround is to turn off the dice roller entirely with dice: false But this seems weird as I have no "dice" formulas with just a single number, do I? Since I do use dice roller for the Actions (to Hit and Damage), it is weird that these do not follow my callback properly. Do you expect a formula (+3 meaning 1d20+3) by default?

This seems to be a bug.

Current behaviour

Reproduction

Create a property with a callback for an element of the stats[] array.
Create a statblock with stats similar to stats[0,0,0,1,1,1]
Visualise it with and without the dice roller enabled.

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version Check

1.8.10

Plugin Version

FS 4.9.0, DR 11.4.2

Confirmation

• I have disabled all other plugins and the issue still persists.

Possible solution

No response

[namtrah]

Hi, this still seems to break for me. I cannot see that it is fixed in Live Preview mode. although it does seem fixed in Reader mode

[ebullient]

Live Preview and reading modes are sometimes different animals, though I wouldn't expect it to impact parsing that way.

What happens if you remove (do not specify) the empty diceCallback? I can't remember how that is supposed to work, but it could be that the lack of return from callback/diceCallback is part of the problem. Both of those are supposed to return values..

[ebullient]

• fantasy-statblocks/CHANGELOG.md

  Line 436 in 0e78807

  * Fixes issue where having DR installed but not enabled in FS would erroneously run dice callbacks ([2fa84c1](https://github.com/javalent/fantasy-statblocks/commit/2fa84c1ba2c48a5b7c672724b271df466eefef05))

• fantasy-statblocks/CHANGELOG.md

  Line 575 in 0e78807

  * Remove requirement to have Parse for Dice turned on to use Dice Callbacks ([a8bab50](https://github.com/javalent/fantasy-statblocks/commit/a8bab50c31b46c455c9fb5158a68da9397b9da76))

• fantasy-statblocks/CHANGELOG.md

  Line 2003 in 0e78807

  * dice enabled blocks now default to using plugin parse method if no property or callback is provided ([f6fa7eb](https://github.com/valentine195/obsidian-5e-statblocks/commit/f6fa7ebf3d139be72726f80506a7fce56135adea))

[namtrah]

I removed the callback. Instead of a number I received a - symbol. This is in my eyes still incorrect. I expect the number in the stat block (without any calculation).

[ebullient]

what happens if you have the function just return the number?

[namtrah]

what happens if you have the function just return the number?

The same with above in the "Current behavior" section. Nothing changed.