Add support for additional variables with 5etools importer #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching on space was too permissive and would cut values like "Difficult Terrain" short. This is trying to ensure we match:
{@variantrule Cone [Area of Effect]|XPHB}
and
{@variantrule Difficult Terrain|XPHB}
Realized a rare variable from 5eTools for hom "Hit or Miss:" which is used by 12 creatures from the 2024 MM. Adding replacement.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add additional parseString variables to the 5eToolsImport to account for updates to the 2025 Monster Manual.
Changes Proposed
Update now supports:
Related Issues
Fixes #Issue_Number
Checklist
Additional Notes
To fully support 5eTools, more changes are needed including supporting multiple sizes and storing lair attributes but this is a start.