Skip to content

Conversation

@GulajavaMinistudio
Copy link

No description provided.

mcollina and others added 5 commits January 6, 2025 07:22
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #56428
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Refs: #55006
Refs: #54807 (comment)
PR-URL: #56470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Update parallel/test-tls-psk-circuit.js to account for error code
changes in OpenSSL 3.4 and probably later.

Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
PR-URL: #56420
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #53595
Refs: #53751
PR-URL: #56472
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #56328
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@GulajavaMinistudio GulajavaMinistudio merged commit 9c9b668 into javascript-indonesias:master Jan 7, 2025
21 of 23 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.40506% with 545 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (b736028) to head (062ae6f).
Report is 1044 commits behind head on master.

Files with missing lines Patch % Lines
src/quic/http3.cc 7.23% 217 Missing and 1 partial ⚠️
src/quic/streams.cc 43.39% 89 Missing and 31 partials ⚠️
src/quic/application.cc 40.98% 57 Missing and 15 partials ⚠️
lib/internal/quic/state.js 59.00% 41 Missing ⚠️
src/quic/endpoint.cc 58.06% 28 Missing and 11 partials ⚠️
src/quic/packet.cc 35.00% 19 Missing and 7 partials ⚠️
src/quic/tlscontext.cc 47.36% 3 Missing and 7 partials ⚠️
src/quic/transportparams.cc 58.33% 4 Missing and 1 partial ⚠️
src/quic/data.cc 33.33% 2 Missing and 2 partials ⚠️
src/node_http_common-inl.h 0.00% 2 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   88.44%   89.05%   +0.60%     
==========================================
  Files         658      660       +2     
  Lines      190450   191120     +670     
  Branches    36496    36730     +234     
==========================================
+ Hits       168449   170197    +1748     
+ Misses      15242    13845    -1397     
- Partials     6759     7078     +319     
Files with missing lines Coverage Δ
lib/internal/blob.js 99.80% <100.00%> (+<0.01%) ⬆️
lib/internal/bootstrap/realm.js 96.25% <100.00%> (+0.21%) ⬆️
.../internal/bootstrap/switches/is_not_main_thread.js 100.00% <100.00%> (ø)
lib/internal/process/pre_execution.js 91.70% <100.00%> (+1.00%) ⬆️
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/quic/stats.js 95.25% <100.00%> (+0.21%) ⬆️
lib/internal/quic/symbols.js 100.00% <100.00%> (ø)
lib/internal/worker/io.js 99.17% <100.00%> (+<0.01%) ⬆️
lib/quic.js 100.00% <100.00%> (ø)
src/node_builtins.cc 78.53% <100.00%> (+0.05%) ⬆️
... and 30 more

... and 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants