feat: Add unit testing with mocked Git and GitHub CLIs #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GitClient and GitHubClient interfaces for dependency injection - Refactor git, github, and stack packages to use interface-based clients - Update all command functions to accept client parameters (no backward compatibility) - Create comprehensive test utilities with mocks and fixtures using testify - Add package-level tests for stack (70.8% coverage), git, and github packages - Add command-level tests for new, sync, and status commands - Add testify dependency to go.mod - Update all cmd files (new, sync, status, parent, prune, rename, reparent, worktree, root) to use dependency injection All git and github CLI calls are now mockable for fast, isolated unit tests.
- Use .Maybe() for GetDefaultBranch and GetConfig(stack.baseBranch) calls in sync tests - Add missing GetWorktreeBranches and GetCurrentWorktreePath mocks - Update GetAllStackParents to use .Maybe() to handle variable call counts - Fix TestRunStatus to not expect GetAllPRs when noPR is true All tests now passing with proper mock expectations.
Update all sync tests to use .Maybe() instead of .Times(4) for GetAllStackParents to handle variable call counts across different code paths.
Owner
Author
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds comprehensive unit testing infrastructure to Stackinator, enabling fast, isolated tests by mocking all Git and GitHub CLI interactions.
Key Changes
Dependency Injection Architecture
Test Infrastructure
Test Coverage
cmd package: 32.5% coverage
internal/stack package: 70.8% coverage
internal/git and github packages: Interface validation tests
Benefits
Files Changed
All tests passing