fixed bug, not being able to write code on the first line#10
Merged
jaykv merged 1 commit intojaykv:mainfrom Feb 19, 2024
Merged
fixed bug, not being able to write code on the first line#10jaykv merged 1 commit intojaykv:mainfrom
jaykv merged 1 commit intojaykv:mainfrom
Conversation
Owner
|
Thanks for fixing this! I'll get this out in a new version. Glad you like the project :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, first of all this is my first pull request. (Sorry if I dont really know what I'm doing)
Second of all, pybash currently gets a syntax error anytime it parses a file that has code on the first line, this is because of this line in import_hook.py:
Its basically doing
"import subprocess" + source, which concatenates the import line and the first line of the code.I changed it to
"import subprocess\n"so that the import stays on its own line.p.s. your project is really cool, thanks for making it :)