Configure SubType via object with more customizations#5
Open
ianwremmel wants to merge 4 commits intojayyvis:masterfrom
Open
Configure SubType via object with more customizations#5ianwremmel wants to merge 4 commits intojayyvis:masterfrom
ianwremmel wants to merge 4 commits intojayyvis:masterfrom
Conversation
…) and constructor parameter handling
…; make name, message non-enumerable props toString() does not work consistently so rely on parseFn to set message in a way the native toString() will render it parseFn needs to be on the prototype so parent implementations can be invoked from subclasses make name and message non-enumerable so they do not get double-rendered when calling console.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs some tests, but much more robust than #4.
extend()now accepts an options object as alternative to thesubTypeNameanderrorCodeparameters.Decreases emphasis on HTTP-related errors. (instead of passing
errorCode, add{properties: {code: <code>}}to theoptionsobject.Adds ability to provide alternate
toString().Adds
parseFn(), which can do additional processing on the SubType constructor argument. I'm primarily envisioning it as a way to wrap http error responses with an Error:Just like Make monkeypatching optional #4, makes monkeypatching optional.