Use CMake find_package and official targets instead of libray names #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
3 tasks
jbaldwin
previously approved these changes
Dec 12, 2025
Owner
|
great changes, thank you for opening these PRs edit: it looks like the ci workflows might need some updates to find the packages correctly |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Contributor
Author
|
The libuv officially provides the mentioned Config Cmake, as described in previously. However, Ubuntu does not bring the latest project revision, so it does not package that expected .cmake file. Still, Ubuntu provides the .pc file: https://packages.ubuntu.com/questing/amd64/libuv1-dev/filelist Which can be used through pkg-config. I added a fallback to use pkg-config in case not find the expected .cmake file. |
jbaldwin
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As a continuation of #177, this PR replaces the usage of regular library names by official CMake targets instead:
Using CMake targets, it will not only solve the correct library path, but also list transitive dependencies, compiler definitions, and header folders.
Regards!