fix: use USERPROFILE on Windows for non-ASCII username support#2450
Open
Bhumika-SN wants to merge 2 commits intojbangdev:mainfrom
Open
fix: use USERPROFILE on Windows for non-ASCII username support#2450Bhumika-SN wants to merge 2 commits intojbangdev:mainfrom
Bhumika-SN wants to merge 2 commits intojbangdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, users with non-ASCII characters in their username (common
in many countries including India, China, Eastern Europe) experience
broken PATH setup and jbang failing completely.
Root cause: Java's
System.getProperty("user.home")can return acorrupted path on Windows when the username contains non-ASCII characters.
Fix
On Windows, prefer
USERPROFILEenvironment variable overuser.homeas it always returns the correct path regardless of username characters.
Related Issue
Fixes #1110